Add layer control tree plugin #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansthen
force-pushed
the
layer_control_tree
branch
2 times, most recently
from
0192975 to
884ed3a
Compare
Conengmo
reviewed
Apr 3, 2024
There was a problem hiding this comment.
Looks good! Useful plugin, nice implementation. Very complete with documentation.
Some very minor comments. I do want to split out the tojavascript part in a separate PR, so we'd have to update this branch when that has been merged. But should be easy to merge after that.
|
Update this branch once #1912 has been merged. |
hansthen
force-pushed
the
layer_control_tree
branch
from
11422ac to
732accf
Compare
|
For some reason the updating from main didn't go as expected, I'm seeing the changes that are in main also in the diff here. Maybe something to be mindful of next time. I suppose when I merge this PR it will not cause an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the
Leaflet.Control.Layers.Treein Folium. See https://github.com/jjimenezshaw/Leaflet.Control.Layers.Tree for more details.Closes: #1606