Use pkgutil.get_data for zip-safe resource loading #2974
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When installed in a Zip file ('zipapp', '*.pyz') loading resources
from package data can not be done by directly reading files relative
to '__file__', since there is no valid path on the file system for
zipped files.
Using 'pkgutil.get_data' ensures that loading files from a Zip archive
is handled accordingly.
GitHub: python-poetry#2965
|
Bug fixes go only on |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installed in a Zip file (
zipapp,*.pyz) loading resourcesfrom package data can not be done by directly reading files relative
to
__file__, since there is no valid path on the file system forzipped files.
Using 'pkgutil.get_data' ensures that loading files from a Zip archive
is handled accordingly.
Resolves: #2965