Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JPEG XL Open/Read support via libjxl #7848
base: main
Are you sure you want to change the base?
Add JPEG XL Open/Read support via libjxl #7848
Changes from 8 commits
8e0c5db
a57ebea
23fb57d
2eb5987
37b58f3
eeaecb4
24b63ad
0b50410
f403672
f6086d4
5320450
1b049ab
6048520
8fa280f
58c37bf
48bbc2e
443a352
62c58c2
8cab1c1
e5003ff
fa5bfac
0b71605
1f00fb8
08270a7
9313587
4256b2a
8a1c03e
13944d5
bb06057
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 80 in Tests/test_file_jxl_metadata.py
Codecov / codecov/patch
Tests/test_file_jxl_metadata.py#L80
Check warning on line 84 in Tests/test_file_jxl_metadata.py
Codecov / codecov/patch
Tests/test_file_jxl_metadata.py#L84
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can we find out the correct limit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it on release version of libjxl and I've set it to 6 megabytes which seem to work well, that's also similar to memory usage of
djxl
for decodinghopper.jxl
.I think libjxl memory usage could depend also on number of decoding threads used. By default we use all available cores.