Improve extract performance via ignoring directories early during os.walk

[akx]

Closes #694 (rebases and reimplements it)

[codecov]

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.31%. Comparing base (8e10fb5) to head (c68ca01).

Files with missing lines	Patch %	Lines
babel/messages/extract.py	92.85%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #968      +/-   ##
==========================================
- Coverage   91.31%   91.31%   -0.01%     
==========================================
  Files          27       27              
  Lines        4653     4661       +8     
==========================================
+ Hits         4249     4256       +7     
- Misses        404      405       +1     

Flag	Coverage Δ
macos-14-3.10	90.32% <92.85%> (-0.01%)	⬇️
macos-14-3.11	90.25% <92.85%> (-0.01%)	⬇️
macos-14-3.12	90.47% <92.85%> (-0.01%)	⬇️
macos-14-3.13	90.47% <92.85%> (-0.01%)	⬇️
macos-14-3.8	90.18% <92.85%> (-0.01%)	⬇️
macos-14-3.9	90.25% <92.85%> (-0.01%)	⬇️
macos-14-pypy3.10	90.32% <92.85%> (-0.01%)	⬇️
ubuntu-24.04-3.10	90.34% <92.85%> (-0.01%)	⬇️
ubuntu-24.04-3.11	90.28% <92.85%> (-0.01%)	⬇️
ubuntu-24.04-3.12	90.49% <92.85%> (-0.01%)	⬇️
ubuntu-24.04-3.13	90.49% <92.85%> (-0.01%)	⬇️
ubuntu-24.04-3.8	90.21% <92.85%> (-0.01%)	⬇️
ubuntu-24.04-3.9	90.27% <92.85%> (-0.01%)	⬇️
ubuntu-24.04-pypy3.10	90.34% <92.85%> (-0.01%)	⬇️
windows-2022-3.10	90.35% <92.85%> (-0.01%)	⬇️
windows-2022-3.11	90.29% <92.85%> (-0.01%)	⬇️
windows-2022-3.12	90.50% <92.85%> (-0.01%)	⬇️
windows-2022-3.13	90.50% <92.85%> (-0.01%)	⬇️
windows-2022-3.8	90.32% <92.85%> (-0.01%)	⬇️
windows-2022-3.9	90.28% <92.85%> (-0.01%)	⬇️
windows-2022-pypy3.10	90.35% <92.85%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[akx]

@DenverCoder1 If you have a moment, could you review this? :)

[DenverCoder1]

Looks good to me (I haven't tested)

I noticed a similar method in frontend.py -

babel/babel/messages/frontend.py

Lines 277 to 288 in 373a52f

	def _make_directory_filter(ignore_patterns):
	"""
	Build a directory_filter function based on a list of ignore patterns.
	"""
	def cli_directory_filter(dirname):
	basename = os.path.basename(dirname)
	return not any(
	fnmatch.fnmatch(basename, ignore_pattern)
	for ignore_pattern
	in ignore_patterns
	)
	return cli_directory_filter

- it seems to not need to create relative paths there, but maybe it's different. Possibly some logic could be combined or renamed to be consistent, but besides that, it seems like this should work.

[tomasr8]

Would this function be considered part of the public API? If so, shouldn't we deprecate it first?

[tomasr8]

This line's missing test coverage ;)