Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pyth Sample EVM Price Feeds #40

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Pyth Sample EVM Price Feeds #40

merged 3 commits into from
Dec 18, 2024

Conversation

aditya520
Copy link
Member

No description provided.

@aditya520 aditya520 marked this pull request as ready for review December 13, 2024 20:42
@aditya520 aditya520 changed the title initial commit Pyth Sample EVM Price Feeds Dec 13, 2024
@ali-bahjati
Copy link
Contributor

What's the purpose of this example?

@aditya520
Copy link
Member Author

This is kind of hello-world example that is requested by alot of new devs during hackathons.

ali-bahjati
ali-bahjati approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@ali-bahjati ali-bahjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think a good helloworld one can be even simpler, get a price and emit a log for it.

@aditya520
Copy link
Member Author

I wanted to show that one can update multiple prices in a single call. That's why we have two methods.

@aditya520 aditya520 merged commit d36a6be into main Dec 18, 2024
4 checks passed
@aditya520 aditya520 deleted the chore(pricefeed)-add-basic-example branch December 18, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ali-bahjati ali-bahjati ali-bahjati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aditya520 @ali-bahjati