Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fortuna): add metrics for retry count, gas/fee multipliers, and fee estimates #2258

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Changes

Added additional metrics tracking to the Fortuna keeper:

  • Added histogram metrics for retry counts in successful transactions
  • Added histogram metrics for final gas multiplier in successful transactions
  • Added histogram metrics for final priority fee multiplier in successful transactions
  • Added histogram metrics for priority fee estimates
  • Added histogram metrics for estimated keeper fees before thresholds

The gas and priority fee multipliers are now tracked in process_event_with_backoff and calculated from num_retries using the EscalationPolicyConfig.

Testing

The changes have been verified by:

  • Running pre-commit hooks including Cargo format and clippy
  • Manual code review to ensure metrics are only tracked for successful transactions
  • Verified correct calculation of multipliers using EscalationPolicyConfig

Link to Devin run: https://app.devin.ai/sessions/a9451eb4c1b448918362b9af66bd5564

…fee estimates

Added histogram metrics to track:
- Number of retries for successful transactions
- Final gas multiplier for successful transactions
- Final fee multiplier for successful transactions
- Priority fee estimate before thresholds
- Estimated keeper fee before thresholds

Co-Authored-By: Jayant Krishnamurthy <[email protected]>
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 1:36am
proposals ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 1:36am
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 1:36am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
component-library ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 1:36am
insights ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 1:36am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant