fix(apps/hermes/server): add crypto redemption rate asset type #2112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
ali-bahjati
force-pushed
the
fix/hermes-asset-type
branch
from
124a271 to
4c8665d
Compare
cctdaniel
approved these changes
Nov 12, 2024
ali-bahjati
force-pushed
the
fix/hermes-asset-type
branch
from
4c8665d to
438e559
Compare
Riateche
reviewed
Nov 12, 2024
Comment on lines
339
to
+350
| impl Display for AssetType { | ||
| fn fmt(&self, f: &mut Formatter) -> FmtResult { | ||
| write!(f, "{:?}", self) | ||
| match self { | ||
| AssetType::Crypto => write!(f, "crypto"), | ||
| AssetType::FX => write!(f, "fx"), | ||
| AssetType::Equity => write!(f, "equity"), | ||
| AssetType::Metal => write!(f, "metal"), | ||
| AssetType::Rates => write!(f, "rates"), | ||
| AssetType::CryptoRedemptionRate => write!(f, "crypto_redemption_rate"), | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Maybe implement it using serde? It's an extra allocation but that shouldn't matter too much.
impl Display for AssetType {
fn fmt(&self, f: &mut Formatter) -> FmtResult {
let value = serde_json::to_value(self).unwrap();
write!(f, "{}", value.as_str().unwrap())
}
}
(You can also use serde_value instead of serde_json).
There was a problem hiding this comment.
yeah that works but i wanted to be explicit here. and being explicit here actually helped me capture a bug :D (in snake_case FX becomes f_x). I could possibly have explicit tests though but the benefit here is that if i add a new field i won't miss adding this explicit definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changes Metals to Metal to match the asset type correctly.