feat(staking): add governance ui methods #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
keyvankhademi
changed the title
guibescos
reviewed
Sep 19, 2024
| * The formula is n_staked_tokens = scaling_factor * n_voter_weight | ||
| */ | ||
| public async getScalingFactor(): Promise<number> { | ||
| const targetAccount = await this.getTargetAccount(); |
There was a problem hiding this comment.
Note: this is only valid if someone has cranked the target account (happens whenever someone stakes to unstakes, or whenever someome slashes). I generally think this approach seems fine
guibescos
reviewed
Sep 19, 2024
guibescos
approved these changes
Sep 19, 2024
guibescos
reviewed
Sep 20, 2024
| } | ||
|
|
||
| const scalingFactor = await this.getScalingFactor(); | ||
| return Number(mainAccount.balance) / scalingFactor; |
There was a problem hiding this comment.
It needs to be the voter weight, that is the sum of all positions that have governance target and are active
guibescos
reviewed
Sep 20, 2024
| const currentAccount = stakeAccountBalances[i]; | ||
| if ( | ||
| currentAccount !== undefined && | ||
| currentAccount.balance > mainAccount.balance |
There was a problem hiding this comment.
Sort by voterWeight not by balance
guibescos
reviewed
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.