fix: feed rpc responses and notifications instead of send and flush #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-bahjati
force-pushed
the
fix/feed-notifications-instead-of-flushing
branch
from
cf646e5 to
a5322cd
Compare
ali-bahjati
changed the title
ali-bahjati
force-pushed
the
fix/feed-notifications-instead-of-flushing
branch
2 times, most recently
from
44421f4 to
e8716ad
Compare
ali-bahjati
force-pushed
the
fix/feed-notifications-instead-of-flushing
branch
from
e8716ad to
7ea4825
Compare
Reisen
approved these changes
Aug 1, 2024
ali-bahjati
force-pushed
the
fix/feed-notifications-instead-of-flushing
branch
from
7ea4825 to
6067d5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We might send thousands of messages per second to the clients and
sendmethod flushes each request which might take a longer time. This change changes our responses and notifications tofeedand flushes the messages based on a configured interval (default: 100ms).There is a small refactor of a config in the previous changes to make it match our configuration style.