Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/update loop gone #20

Merged
merged 2 commits into from
Oct 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion example_publisher/provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,14 @@ class Price:


class Provider(ABC):
_update_loop_task = None

@abstractmethod
def upd_products(self, product_symbols: List[Symbol]):
...

def start(self) -> None:
asyncio.create_task(self._update_loop())
self._update_loop_task = asyncio.create_task(self._update_loop())

@abstractmethod
async def _update_loop(self):
Expand Down
3 changes: 2 additions & 1 deletion example_publisher/providers/pyth_replicator.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ def __init__(self, config: PythReplicatorConfig) -> None:
self._prices: Dict[
str, Tuple[float | None, float | None, UnixTimestamp | None]
] = {}
self._update_accounts_task: asyncio.Task | None = None

async def _update_loop(self) -> None:
self._ws = self._client.create_watch_session()
Expand All @@ -41,7 +42,7 @@ async def _update_loop(self) -> None:
self._config.program_key, await self._client.get_all_accounts()
)

asyncio.create_task(self._update_accounts_loop())
self._update_accounts_task = asyncio.create_task(self._update_accounts_loop())

while True:
update = await self._ws.next_update()
Expand Down
5 changes: 4 additions & 1 deletion example_publisher/publisher.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ class Product:
class Publisher:
def __init__(self, config: Config) -> None:
self.config: Config = config
self._product_update_task: asyncio.Task | None = None

if not getattr(self.config, self.config.provider_engine):
raise ValueError(f"Missing {self.config.provider_engine} config")
Expand All @@ -48,7 +49,9 @@ def __init__(self, config: Config) -> None:
async def start(self):
await self.pythd.connect()

asyncio.create_task(self._start_product_update_loop())
self._product_update_task = asyncio.create_task(
self._start_product_update_loop()
)

async def _start_product_update_loop(self):
await self._upd_products()
Expand Down
7 changes: 6 additions & 1 deletion example_publisher/pythd.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ def __init__(
self.address = address
self.server: Server = None
self.on_notify_price_sched = on_notify_price_sched
self._notify_price_sched_tasks = set()

async def connect(self) -> Server:
self.server = Server(self.address)
Expand All @@ -69,7 +70,11 @@ async def subscribe_price_sched(self, account: str) -> int:

def _notify_price_sched(self, subscription: int) -> None:
log.debug("notify_price_sched RPC call received", subscription=subscription)
asyncio.get_event_loop().create_task(self.on_notify_price_sched(subscription))
task = asyncio.get_event_loop().create_task(
self.on_notify_price_sched(subscription)
)
self._notify_price_sched_tasks.add(task)
task.add_done_callback(lambda: self._notify_price_sched_tasks.remove(task))

async def all_products(self) -> List[Product]:
result = await self.server.get_product_list()
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "example-publisher"
version = "1.0.1"
version = "1.0.2"
description = ""
authors = []
license = "Apache-2"
Expand Down
Loading