fix: Fix incorrect type check in byteArrayFormat function #546
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hello!
While working with the
byteArrayFormat
function, I noticed an issue with the validation logic for array elements. The original condition:...always fails for valid numbers because
instanceof Number
checks for theNumber
object type, not for primitive numbers. Since numbers in JavaScript are typically primitives, this condition doesn't behave as intended.I've updated the check to use
typeof
instead, which works correctly for primitive numbers:This fix ensures that the function correctly validates the elements of the array.
Type of Change
Checklist
pre-commit run --all-files
to check for linting errorsContributor Information