-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify gherkin terminal reporter to print tags #477
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #477 +/- ##
==========================================
+ Coverage 95.48% 95.93% +0.44%
==========================================
Files 48 49 +1
Lines 1573 1648 +75
Branches 171 179 +8
==========================================
+ Hits 1502 1581 +79
+ Misses 44 41 -3
+ Partials 27 26 -1
Continue to review full report at Codecov.
|
@olegpidsadnyi This is my first time contributing, can you guide me through the PR process? Is there anything else I can do? |
self._tw.write("Feature: ", **feature_markup) | ||
self._tw.write(report.scenario["feature"]["name"], **feature_markup) | ||
self._tw.write("\n") | ||
self._tw.write(self._write_tags(prefix=" ", tags=report.scenario["tags"]), **tag_markup) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be better to use \t
instead of the space bar for a tabulation.
self._tw.write("Feature: ", **feature_markup) | ||
self._tw.write(report.scenario["feature"]["name"], **feature_markup) | ||
self._tw.write("\n") | ||
self._tw.write(self._write_tags(prefix=" ", tags=report.scenario["tags"]), **tag_markup) | ||
self._tw.write("\n") | ||
self._tw.write(" Scenario: ", **scenario_markup) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
Hi @guillego, this looks like something we would like to merge, but it would needs some tests to be added to the PR. |
As mentioned in #476, this PR implements a simple parser for printing the tags in the verbose gherkin terminal reporter.