BH merger logcache fix #264
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad in cached log file when linking BH mergers, rather than loading in log file again
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
…nto BH_merger_logcache_fix
…o is given a halo number of -1
… units for BH mergers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple fixes related to black hole mergers and cached log files
BH mergers now perform the correct unit manipulation that is consistent with the most up-to-date change outputs (the .BHmergers file)
cached BH log files are now used when doing BH linking to save time reading in a large file repeatedly
a major issue related to boxsizes not being appropriately updated for cached logfiles has been resolved. This effects the wrapping of BH positions across the box, so it has only been an issue for BHs near the edge of a volume simulation (zoom simulations should be unaffected).