Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add MDARunner in experimental namespace #197

Merged
merged 10 commits into from
Nov 21, 2024

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Nov 3, 2024

not sure if we'll ever want to merge this, This PR makes the MDARunner from pymmcore-plus available generically to non-micromanager users. (the runner only cares about MDAEvents ...). Of course, in order to be useful, someone would have to implement their own engine. But it's one option to add a "carrot" to useq-schema, and emphasize the separation of concerns...

I'm going to leave it in useq.experimental for now. maybe we can see how we like using it from the pymmcore-plus side

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 95.40816% with 9 lines in your changes missing coverage. Please review.

Project coverage is 94.10%. Comparing base (a5819ef) to head (5e36e07).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/useq/experimental/_runner.py 93.61% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
+ Coverage   93.89%   94.10%   +0.20%     
==========================================
  Files          18       22       +4     
  Lines        1262     1458     +196     
==========================================
+ Hits         1185     1372     +187     
- Misses         77       86       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@tlambert03 tlambert03 marked this pull request as ready for review November 21, 2024 21:19
@tlambert03 tlambert03 changed the title feat: add runner from pymmcore-plus [DRAFT] feat: add MDARunner in experimental namespace Nov 21, 2024
@tlambert03 tlambert03 enabled auto-merge (squash) November 21, 2024 21:24
@tlambert03 tlambert03 merged commit 70b32dd into pymmcore-plus:main Nov 21, 2024
23 checks passed
@tlambert03 tlambert03 deleted the add-runner branch November 21, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant