-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Fix deprecation warning for pivot_longer #1309
Conversation
🚀 Deployed on https://deploy-preview-1309--pyjanitor.netlify.app |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #1309 +/- ##
==========================================
+ Coverage 93.91% 94.64% +0.73%
==========================================
Files 78 78
Lines 4254 4259 +5
==========================================
+ Hits 3995 4031 +36
+ Misses 259 228 -31 |
GitBot Summary of ChangesThe pull request includes several changes across two files: CHANGELOG.md and janitor/functions/pivot.py. In CHANGELOG.md, the changes include:
In janitor/functions/pivot.py, the changes include:
cc: @samukweku, please check for correctness! |
I think this one is good to merge as well, right @samukweku? |
thanks @ericmjl for the reviews |
closed in favour of #1321 |
PR Description
Please describe the changes proposed in the pull request:
**This PR resolves #1308 **
PR Checklist
Please ensure that you have done the following:
<your_username>
:dev
, but rather from<your_username>
:<feature-branch_name>
.AUTHORS.md
.CHANGELOG.md
under the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.