Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bug on iOS Devices: "Ready to Start!" Screen Unresponsive #170

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Dor-sketch
Copy link

Fixes Issue #138 where the "Ready to Start!" screen is unresponsive on iOS devices. Updated the waiting loop in custom_site() in the template HTML files.

Changes Made:

  • Modified the waiting loop in custom_site() to improve event handling on iOS devices.

Testing:

  • Tested on one iOS device; further testing needed on other devices.

@pmp-p
Copy link
Member

pmp-p commented Jul 11, 2024

Thanks, fix indeed works for iOS but it relies on pygame, so it is only valid for "default.tmpl". For the other templates pygame is either not loaded, or must not init canvas contexts. So a javascript solution would have to be used there because browser don't allow to change contexts at runtime.

Also in its present form i fear it would defeat the chrome media-user-engagement learning process which allow often played games to start music automatically without a click. I would prefer is a way with detection that device is iOS and apply the fix only in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants