rolling.construct: Add sliding_window_kwargs to pipe arguments down to sliding_window_view

[dcherian]

Closes #9550
xref #4325

• Tests added
• User visible changes (including notable bug fixes) are documented in whats-new.rst

cc @phofl

Blocked till the next dask release, so we can verify tests

[phofl]

looks good to me!

[max-sixty]

I don't have much context here, but should we always do this if possible, rather than add an option? Or we want to allow an escape hatch for instances where copies are made?

[dcherian]

It is on by default in the public APIs (construct and reduce). Advanced users can opt-out. For internal uses, where copies are not made, I set it to False by default (in _reduce_method) and opt-in to rechunking when necessary for each individual method.

I think we should expose it in construct since that is a thin wrapper around sliding_window_view. Are you concerned about exposing it in reduce?

[max-sixty]

No! Generally keen on keeping the API small but totally reasonable here!

[dcherian]

@max-sixty one option would be to add sliding_window_view_kwargs to forward arbitrary kwargs down to the implementing library. For example, numpy has writeable which someone might want to set (we do not allow this currently)

[dcherian]

I went with sliding_window_kwargs to save some typing...