Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/enable custom datareader #896

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

begoat
Copy link

@begoat begoat commented Aug 2, 2021

@bashtage
Copy link
Contributor

bashtage commented Aug 2, 2021

What does this bring that end users couldn't accomplish with subclassing?

@begoat
Copy link
Author

begoat commented Aug 2, 2021

What does this bring that end users couldn't accomplish with subclassing?

Hi @bashtage

I came across this problem. #895
I cannot figure out one way to request https://stooq.com/q/d/l/?s=USDJPY

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2021

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.54%. Comparing base (b1247d1) to head (a1e7a8e).
Report is 51 commits behind head on main.

Files with missing lines Patch % Lines
pandas_datareader/data.py 78.57% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
- Coverage   73.15%   71.54%   -1.61%     
==========================================
  Files          65       65              
  Lines        2932     2963      +31     
  Branches      315      316       +1     
==========================================
- Hits         2145     2120      -25     
- Misses        705      760      +55     
- Partials       82       83       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stooq.com cannot get data related to USDJPY
3 participants