Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Review Stages Setting #1204

Open
wants to merge 28 commits into
base: master
Choose a base branch
from

Conversation

tomatoprinx
Copy link
Contributor

@tomatoprinx tomatoprinx commented Jul 13, 2024

Types of changes

  • Bugfix
  • New feature
  • Refactoring
  • Breaking change (any change that would cause existing functionality to not work as expected)
  • Documentation Update
  • Other (please describe)

Description

Steps to Test This Pull Request

Steps to reproduce the behavior:

  1. Login with admin account
  2. Go to 'Review Stages' page
  3. Click hotkeys in the 'Set Review Stage' section
  4. Submit

Expected behavior

Related Issue

#782

More Information

reviews_stage_setting

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

Attention: Patch coverage is 26.41509% with 39 lines in your changes missing coverage. Please review.

Project coverage is 73.17%. Comparing base (2a232a0) to head (8b9d274).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
src/reviews/views.py 20.83% 38 Missing ⚠️
src/proposals/templatetags/proposals.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1204      +/-   ##
==========================================
- Coverage   74.01%   73.17%   -0.85%     
==========================================
  Files          81       81              
  Lines        3060     3113      +53     
==========================================
+ Hits         2265     2278      +13     
- Misses        795      835      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josix josix marked this pull request as ready for review September 17, 2024 10:06
@tomatoprinx tomatoprinx requested a review from josix September 18, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants