Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): update the way it attach to the dev container #1192

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mattwang44
Copy link
Member

@mattwang44 mattwang44 commented Apr 18, 2024

Types of changes

  • Bugfix

Description

The current dev script is reported as not working on Windows and Linux.
Note that the author and reviewers of #1172 are all mac users.

What this PR does are:

  • Change the container-attaching behavior
  • Adopt docker compose v2
  • Slightly refactoring for better readability

todos

  • verify on Windows (@ken71301 will help on this part)
  • verify on Max
  • verify on Linux (GitHub codespace)

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.16%. Comparing base (53b0638) to head (7341b7d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1192      +/-   ##
==========================================
- Coverage   71.19%   71.16%   -0.03%     
==========================================
  Files          84       84              
  Lines        3451     3451              
==========================================
- Hits         2457     2456       -1     
- Misses        994      995       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattwang44 mattwang44 requested a review from ken71301 April 18, 2024 15:27
@mattwang44 mattwang44 marked this pull request as draft April 22, 2024 15:30
@mattwang44
Copy link
Member Author

still not working on windows, so it's converted to a draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant