Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: replace flake8 with ruff #1174

Merged
merged 8 commits into from
Apr 15, 2024
Merged

Conversation

mattwang44
Copy link
Member

Types of changes

  • Other (introduce ruff)

Description

Introduce ruff and remove flake8

@mattwang44 mattwang44 marked this pull request as draft April 9, 2024 10:54
@mattwang44 mattwang44 force-pushed the introduce-ruff branch 2 times, most recently from d07f387 to 7859722 Compare April 9, 2024 12:51
@mattwang44 mattwang44 marked this pull request as ready for review April 9, 2024 13:00
@mattwang44 mattwang44 requested review from josix and SivanYeh April 9, 2024 13:01
@mattwang44
Copy link
Member Author

mattwang44 commented Apr 9, 2024

merge 前會再 commit 一份 .git-blame-ignore-revs
done

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 75.17241% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 71.19%. Comparing base (6e1cdbf) to head (f4a11d2).

Files Patch % Lines
.../proposals/management/commands/export_proposals.py 0.00% 5 Missing ⚠️
...anagement/commands/export_proposals_create_time.py 0.00% 4 Missing ⚠️
src/events/views.py 0.00% 3 Missing ⚠️
src/users/models.py 70.00% 3 Missing ⚠️
src/ccip/views.py 66.66% 2 Missing ⚠️
src/core/difftools.py 0.00% 2 Missing ⚠️
src/core/views.py 50.00% 2 Missing ⚠️
src/events/api/views.py 66.66% 2 Missing ⚠️
src/events/models.py 77.77% 2 Missing ⚠️
src/events/renderers.py 66.66% 2 Missing ⚠️
... and 6 more
Additional details and impacted files
@@                    Coverage Diff                    @@
##           upgrade-django-to-3.2    #1174      +/-   ##
=========================================================
+ Coverage                  71.07%   71.19%   +0.12%     
=========================================================
  Files                         84       84              
  Lines                       3440     3451      +11     
=========================================================
+ Hits                        2445     2457      +12     
+ Misses                       995      994       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@SivanYeh SivanYeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will merge after #1172 merged.

@mattwang44 mattwang44 force-pushed the upgrade-django-to-3.2 branch 2 times, most recently from 6375f68 to 6e1cdbf Compare April 13, 2024 08:28
@mattwang44
Copy link
Member Author

rebased

.git-blame-ignore-revs Outdated Show resolved Hide resolved
@mattwang44 mattwang44 merged commit 1050b53 into upgrade-django-to-3.2 Apr 15, 2024
3 checks passed
@mattwang44 mattwang44 deleted the introduce-ruff branch April 15, 2024 07:34
@mattwang44 mattwang44 restored the introduce-ruff branch April 15, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants