Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[smart_holder] Configure only one job per OS kind to build and run tests with -DPYBIND11_USE_SMART_HOLDER_AS_DEFAULT #5307

Merged
merged 5 commits into from
Aug 14, 2024

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Aug 14, 2024

Description

Follow-on to PR #5257, which made it far less important to build and run all tests with py::smart_holder as the default holder.

Remove ci_sh_def.yml

Piggy-backed: Add smart_holder to branches in emscripten.yaml

Suggested changelog entry:

Ralf W. Grosse-Kunstleve added 5 commits August 13, 2024 20:31
…IND11_USE_SMART_HOLDER_AS_DEFAULT`

Remove ci_sh_def.yml

Piggy-backed: Add `smart_holder` to `branches` in emscripten.yaml
…SING_SMART_HOLDER_AS_DEFAULT)"

This reverts commit 4f6f5cb.
@rwgk rwgk marked this pull request as ready for review August 14, 2024 06:58
@rwgk rwgk requested a review from henryiii as a code owner August 14, 2024 06:58
@rwgk rwgk merged commit 0a2efdf into pybind:smart_holder Aug 14, 2024
14 of 16 checks passed
@rwgk rwgk deleted the sh_def_sparse branch August 14, 2024 06:59
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Aug 14, 2024
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant