[smart_holder] Backport of pybind11clif type_caster_std_function_specializations feature.
#5289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…81de4e0ae41d861a5c46903968f7b27 The pybind11k `return_value_policy_pack` and `function_record` changes were backed out. The net diffs to PR pybind#4597 are merely: ```diff +#define PYBIND11_HAS_TYPE_CASTER_STD_FUNCTION_SPECIALIZATIONS ``` ```diff - explicit func_wrapper_base(func_handle &&hf) noexcept : hfunc(hf) {} + explicit func_wrapper_base(func_handle &&hf) noexcept : hfunc(std::move(hf)) {} ```
rwgk
changed the title
type_caster_std_function_specializations feature.type_caster_std_function_specializations feature.
```
/__w/pybind11/pybind11/include/pybind11/functional.h:47:67: error: passing result of std::move() as a const reference argument; no move will actually happen [performance-move-const-arg,-warnings-as-errors]
47 | explicit func_wrapper_base(func_handle &&hf) noexcept : hfunc(std::move(hf)) {}
| ^~~~~~~~~~ ~
/__w/pybind11/pybind11/include/pybind11/functional.h:23:8: note: 'func_handle' is not move assignable/constructible
```
copybara-service bot
pushed a commit
to pybind/pybind11_abseil
that referenced
this pull request
Aug 6, 2024
…turn_value_policy_pack` feature. This is for pybind/pybind11#5289 applied to smart_holder. PiperOrigin-RevId: 659808208
copybara-service bot
pushed a commit
to pybind/pybind11_abseil
that referenced
this pull request
Aug 6, 2024
…turn_value_policy_pack` feature. This is for pybind/pybind11#5289 applied to smart_holder. PiperOrigin-RevId: 659808208
copybara-service bot
pushed a commit
to pybind/pybind11_abseil
that referenced
this pull request
Aug 6, 2024
…turn_value_policy_pack` feature. This is for pybind/pybind11#5289 applied to smart_holder. PiperOrigin-RevId: 659973774
|
The equivalent PR #4597 was merged into master. |
rwgk
changed the title
type_caster_std_function_specializations feature.type_caster_std_function_specializations feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Equivalent of PR #4597 (and google/pybind11clif#30022), but based on pybind11clif main @ commit ab472bbce81de4e0ae41d861a5c46903968f7b27.
The pybind11clif
return_value_policy_packandfunction_recordchanges were backed out.The resulting net diffs to PR #4597 is merely:
+#define PYBIND11_HAS_TYPE_CASTER_STD_FUNCTION_SPECIALIZATIONSFor completeness, note that this
std::moveneeds to be dropped to resolve a clang-tidy error:Suggested changelog entry: