Use seed for all rng in blending to make a test run completely deterministic #450
+82
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #450 +/- ##
==========================================
+ Coverage 84.17% 84.26% +0.09%
==========================================
Files 160 160
Lines 13058 13067 +9
==========================================
+ Hits 10991 11011 +20
+ Misses 2067 2056 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sidekock
approved these changes
Jan 2, 2025
RubenImhoff
approved these changes
Jan 8, 2025
| @@ -274,7 +274,7 @@ def _get_error(scale): | |||
| return shift, scale, R.reshape(shape) | |||
|
|
|||
|
|
|||
| def resample_distributions(first_array, second_array, probability_first_array): | |||
| def resample_distributions(first_array, second_array, probability_first_array, randgen): | |||
There was a problem hiding this comment.
Good to add randgen also in the docstrings below.
There was a problem hiding this comment.
Ah yes indeed, I could also put a default value there to preserve backwards compatibility. I think that might be nicer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some places in the blending code the rng was done without using the provided seed. This meant that a run with a specified seed did not have a completely deterministic outcome and this makes testing harder. This PR fixes this.
See also: #449