Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add features transformation via category encoders and test set transformation based on train #300

Merged
merged 10 commits into from
Jun 20, 2024

Conversation

AlxdrPolyakov
Copy link
Collaborator

@AlxdrPolyakov AlxdrPolyakov commented Jun 18, 2024

Problem

Describe the problem your PR is trying to solve
Okay the first reasonable PR is here, I added category-encoders based categorical features transformation, test transformation based on train. All the previous methods remain for now just in case.

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to causaltune?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

@AlxdrPolyakov AlxdrPolyakov added the change:standard Not an emergency or impactful change label Jun 18, 2024
@AlxdrPolyakov AlxdrPolyakov merged commit dc4cfcb into main Jun 20, 2024
6 of 7 checks passed
@AlxdrPolyakov AlxdrPolyakov deleted the encoders branch September 5, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:standard Not an emergency or impactful change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants