Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug in check_high_dimensional #906

Merged
merged 3 commits into from
Aug 14, 2024
Merged

fix bug in check_high_dimensional #906

merged 3 commits into from
Aug 14, 2024

Conversation

itamarfaran
Copy link
Contributor

No description provided.

@itamarfaran
Copy link
Contributor Author

#905

@itamarfaran itamarfaran mentioned this pull request Aug 5, 2024
Open
kbattocchi
kbattocchi requested changes Aug 11, 2024
View reviewed changes
Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Please add a test that would fail without your fix.

@itamarfaran
add test_check_high_dimensional
a3efc11 
(cherry picked from commit a89d3f8)
@itamarfaran
Copy link
Contributor Author

added :)

@kbattocchi kbattocchi merged commit 1375cde into py-why:main Aug 14, 2024
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbattocchi kbattocchi kbattocchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itamarfaran @kbattocchi