Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added supported for CLI margins option. #32

Closed

Conversation

Niremizov
Copy link

@Niremizov Niremizov commented Aug 7, 2024

Bug reported here camelot-dev#499
camelot-dev#500

@bosd bosd added enhancement New feature or request bug Something isn't working labels Aug 10, 2024
@bosd
Copy link
Collaborator

bosd commented Aug 13, 2024

@Niremizov Thanks for your contribution.
CI should be fixed now. Can you please rebase?

Is it possible to add some unit tests?

bosd and others added 14 commits August 15, 2024 21:16
Update link to point to the new repo
Also remove the `$` from the bash commands to make it copy-pastable for users
* [IMP]: Bump codecov action

* CI: Update to codecov-action@v4
[IMP]: Add pytest-mpl
Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3...v4)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
dependabot bot and others added 25 commits August 29, 2024 13:26
Bumps [opencv-python](https://github.com/opencv/opencv-python) from 4.8.1.78 to 4.10.0.84.
- [Release notes](https://github.com/opencv/opencv-python/releases)
- [Commits](https://github.com/opencv/opencv-python/commits)

---
updated-dependencies:
- dependency-name: opencv-python
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [rich](https://github.com/Textualize/rich) from 13.7.1 to 13.8.0.
- [Release notes](https://github.com/Textualize/rich/releases)
- [Changelog](https://github.com/Textualize/rich/blob/master/CHANGELOG.md)
- [Commits](Textualize/rich@v13.7.1...v13.8.0)

---
updated-dependencies:
- dependency-name: rich
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [typer](https://github.com/fastapi/typer) from 0.12.4 to 0.12.5.
- [Release notes](https://github.com/fastapi/typer/releases)
- [Changelog](https://github.com/fastapi/typer/blob/master/docs/release-notes.md)
- [Commits](fastapi/typer@0.12.4...0.12.5)

---
updated-dependencies:
- dependency-name: typer
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [stevedore](https://docs.openstack.org/stevedore/latest/) from 5.2.0 to 5.3.0.

---
updated-dependencies:
- dependency-name: stevedore
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [safety](https://github.com/pyupio/safety) from 3.2.5 to 3.2.7.
- [Release notes](https://github.com/pyupio/safety/releases)
- [Changelog](https://github.com/pyupio/safety/blob/main/CHANGELOG.md)
- [Commits](pyupio/safety@3.2.5...3.2.7)

---
updated-dependencies:
- dependency-name: safety
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [idna](https://github.com/kjd/idna) from 3.7 to 3.8.
- [Release notes](https://github.com/kjd/idna/releases)
- [Changelog](https://github.com/kjd/idna/blob/master/HISTORY.rst)
- [Commits](kjd/idna@v3.7...v3.8)

---
updated-dependencies:
- dependency-name: idna
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [zipp](https://github.com/jaraco/zipp) from 3.20.0 to 3.20.1.
- [Release notes](https://github.com/jaraco/zipp/releases)
- [Changelog](https://github.com/jaraco/zipp/blob/main/NEWS.rst)
- [Commits](jaraco/zipp@v3.20.0...v3.20.1)

---
updated-dependencies:
- dependency-name: zipp
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [safety-schemas](https://github.com/pyupio/safety_schemas) from 0.0.4 to 0.0.5.
- [Commits](https://github.com/pyupio/safety_schemas/commits)

---
updated-dependencies:
- dependency-name: safety-schemas
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [importlib-resources](https://github.com/python/importlib_resources) from 6.4.3 to 6.4.4.
- [Release notes](https://github.com/python/importlib_resources/releases)
- [Changelog](https://github.com/python/importlib_resources/blob/main/NEWS.rst)
- [Commits](python/importlib_resources@v6.4.3...v6.4.4)

---
updated-dependencies:
- dependency-name: importlib-resources
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [pbr](https://docs.openstack.org/pbr/latest/) from 6.0.0 to 6.1.0.

---
updated-dependencies:
- dependency-name: pbr
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [pyparsing](https://github.com/pyparsing/pyparsing) from 3.1.2 to 3.1.4.
- [Release notes](https://github.com/pyparsing/pyparsing/releases)
- [Changelog](https://github.com/pyparsing/pyparsing/blob/master/CHANGES)
- [Commits](pyparsing/pyparsing@pyparsing_3.1.2...3.1.4)

---
updated-dependencies:
- dependency-name: pyparsing
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [certifi](https://github.com/certifi/python-certifi) from 2024.7.4 to 2024.8.30.
- [Commits](certifi/python-certifi@2024.07.04...2024.08.30)

---
updated-dependencies:
- dependency-name: certifi
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@Niremizov
Copy link
Author

Tried rebase, but now too many commits are in pull request list. Seems it would be easier to close this pull and create new one. Would try this later.

@Niremizov
Copy link
Author

See cmt above.

@Niremizov Niremizov closed this Sep 2, 2024
@Niremizov
Copy link
Author

New pull is here #111
Still tests are needed.

@Niremizov
Copy link
Author

Added tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants