Bugfix: Clickhouse connect a closed network that will crash process.

pwnsky · Mar 9, 2024 · 8f124b3 · 8f124b3
1 parent 1f4c74b
commit 8f124b3
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/node/db_proxy/clickhouse/clickhouse_module.cc b/src/node/db_proxy/clickhouse/clickhouse_module.cc
@@ -71,8 +71,14 @@ bool ClickhouseModule::Connect() {
 	int port = m_element_->GetPropertyInt32(id, excel::DB::Port());
 	string password = m_element_->GetPropertyString(id, excel::DB::Auth());
 	/// Initialize client connection.
-	client_ = new Client(ClientOptions().SetHost(ip).SetPort(port).SetPassword(password));
-
+	try {
+		client_ = new Client(ClientOptions().SetHost(ip).SetPort(port).SetPassword(password));
+	}
+	catch (const std::exception& e) {
+		std::cout << "Click connect error: " << e.what() << std::endl;
+		return false;
+	}
+
 	// Create a table.
 	client_->Execute("CREATE TABLE IF NOT EXISTS default.numbers (id UInt64, name String) ENGINE = Memory");