[DO NOT MERGE] conditionally filter schematic components to galaxy #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Be Done
galaxyID=-1
)Summary
0
is non-NGE, relevant IDs:0, 1337
-1
is NGE, relevant IDs:-1, 1337
1337
is Jedi (shared), relevant IDs:-1, 1337
dbShared.getBaseProfs/1
dbShared.getBaseProfs/1
was refactored to short-circuit returns when value is-1
,0
, or1337
galaxy in (-1, 0, 1337)
)Screen Shots
Base schematic with custom components on different servers
In this case, we have two different servers ("Other" and "Test Server"). "Other" has a custom component
Super Custom Rifle Barrel
. "Test Server" has a custom componentVery Advanced Blaster Rifle Barrel
. Previously, both custom components would always show. Now, they only show when their respective galaxies are selected.Viewing a custom schematic from a different server
When viewing a custom schematic for a different server than selected, we display a notice above the schematic details, informing the user that not all ingredients may be available on their server. In this case, we always filter components to the schematic's galaxy (as well as where
galaxy=0
).