-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Part1: Forward notifications between StorIOSQLite v1 and v3 #876
Conversation
Codecov Report
@@ Coverage Diff @@
## master #876 +/- ##
============================================
+ Coverage 97.99% 98.01% +0.01%
- Complexity 815 819 +4
============================================
Files 98 99 +1
Lines 2787 2815 +28
Branches 308 310 +2
============================================
+ Hits 2731 2759 +28
Misses 27 27
Partials 29 29
Continue to review full report at Codecov.
|
a63fc35
to
97b030c
Compare
97b030c
to
d40a759
Compare
73784a8
to
75ef845
Compare
@nikitin-da @artem-zinnatullin Do you think that it is a good idea to have it? I mean a migration to a newer version shouldn't be hard and it is a lot of code to maintain and care about. |
@geralt-encore happy new year man! 🎄 🍾 🍊 |
I'm totally agree that migration of storio itself is not a big deal and can be done by single pull request.
Firstly I thought that some gist with notifications sharing will be enough. But lately realized that I have to migrate changes and mapping as well. It is not feet to gist and requires tests.. Or maybe we should create another repository and publish it independently like it do @akarnokd. |
I see what problem you are trying to solve and it feels more like RxJava migration related than StorIO related. Also, it might get out of hand pretty fast. Imagine that we would release storio4 and 3 more migrations are needed. I like the idea of keeping it in separate repo and publishing as an independent artefact. |
Part of #875