Switch to voxpupuli-rubocop #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
commented
Jun 9, 2024
| # Include: **/*.gemspec | ||
| Gemspec/RequireMFA: | ||
| # Configuration parameters: Width, AllowedPatterns. | ||
| Layout/IndentationWidth: |
There was a problem hiding this comment.
I can work on cleaning this up after the PR got accepted. I didn't want to invest too much time right now.
bastelfreak
force-pushed
the
vr
branch
2 times, most recently
from
57263f6 to
3e68eef
Compare
|
the rubocop rake task should also run in CI, but I'm not sure how Puppet would like to have their CI setup. Example setup how we do it at Vox Pupuli: https://github.com/voxpupuli/voxpupuli-release/blob/master/.github/workflows/test.yml |
david22swan
approved these changes
Jun 28, 2024
In the past puppetlabs_spec_helper pulls in an undefined version of RuboCop. RuboCop is known for introducing breaking changes in minor releases. voxupuli-rubocop provides a curated version of rubocop + dependencies + a RuboCop config based on community best practices. In addition dependabot is used to inform people about new voxpupuli-rubocop updates. This will ensure that puppetlabs_spec_helper won't randomly pull in new RuboCop versions that break CI again.
|
@david22swan conflict resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past puppetlabs_spec_helper pulls in an undefined version of RuboCop. RuboCop is known for introducing breaking changes in minor releases. voxupuli-rubocop provides a curated version of rubocop + dependencies + a RuboCop config based on community best practices. In addition dependabot is used to inform people about new voxpupuli-rubocop updates. This will ensure that puppetlabs_spec_helper won't randomly pull in new RuboCop versions that break CI again.
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist