Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-1653) Fix rubocop warnings #421

Merged
merged 1 commit into from
Dec 19, 2023
Merged

(CAT-1653) Fix rubocop warnings #421

merged 1 commit into from
Dec 19, 2023

Conversation

gavindidrichsen
Copy link
Contributor

@gavindidrichsen gavindidrichsen commented Dec 19, 2023

Summary

Prior to this fix, CI nightly was failing with:

Run bundle exec rubocop --format github

Error: Performance/StringIdentifierArgument: Use `:"disable_#{check}"` instead of `"disable_#{check}"`.
Error: Process completed with exit code 1.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

Signed-off-by: Gavin Didrichsen <[email protected]>
@gavindidrichsen gavindidrichsen marked this pull request as ready for review December 19, 2023 12:00
@gavindidrichsen gavindidrichsen requested review from bastelfreak and a team as code owners December 19, 2023 12:00
@jordanbreen28 jordanbreen28 merged commit 7aeddea into main Dec 19, 2023
7 of 8 checks passed
@jordanbreen28 jordanbreen28 deleted the cat1653_fix_rubocop branch December 19, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants