Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdksync - "(CAT-1618) - Add code coverage to ci" #67

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

jordanbreen28
Copy link
Contributor

"(CAT-1618) - Add code coverage to ci"
pdk version: 3.0.0

@jordanbreen28 jordanbreen28 requested a review from a team as a code owner January 15, 2024 14:00
@jordanbreen28 jordanbreen28 added the maintenance maintenance label Jan 15, 2024
@jordanbreen28 jordanbreen28 force-pushed the pdksync_"cat-1618-add_code_cov" branch 2 times, most recently from 1cbfe69 to 35a8080 Compare January 15, 2024 14:13
@jordanbreen28 jordanbreen28 force-pushed the pdksync_"cat-1618-add_code_cov" branch from 35a8080 to f7a7511 Compare January 15, 2024 15:31
@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (9a1edca) 95.40% compared to head (f7a7511) 72.72%.
Report is 58 commits behind head on main.

Files Patch % Lines
lib/puppet/modulebuilder/builder.rb 64.70% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #67       +/-   ##
===========================================
- Coverage   95.40%   72.72%   -22.68%     
===========================================
  Files           2        2               
  Lines         174      165        -9     
===========================================
- Hits          166      120       -46     
- Misses          8       45       +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit 9dd2f5a into main Jan 15, 2024
10 checks passed
@LukasAud LukasAud deleted the pdksync_"cat-1618-add_code_cov" branch January 15, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants