-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove bridgedProvider test utilities in favour of ToProviderInfo #2812
Remove bridgedProvider test utilities in favour of ToProviderInfo #2812
Conversation
This change is part of the following stack: Change managed by git-spice. |
74d9520
to
814b7b9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2812 +/- ##
==========================================
+ Coverage 68.63% 68.66% +0.03%
==========================================
Files 325 325
Lines 41579 41579
==========================================
+ Hits 28537 28551 +14
+ Misses 11437 11423 -14
Partials 1605 1605 ☔ View full report in Codecov by Sentry. |
bridgedProvider
utilities in favour of ToProviderInfo
bridgedProvider
utilities in favour of ToProviderInfo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consuming #2805 sounds great. I don't understand why we are removing crosstests.DisableAccurateBridgePreview()
. Can you explain what's going on there?
814b7b9
to
13d6e52
Compare
13d6e52
to
64c6d07
Compare
This PR has been shipped in release v3.101.0. |
This PR is refactors the PF tests to remove the
bridgedProvider
utilities in favour of the newToProviderInfo
method on theproviderbuilder
class. Gets rid of some duplicated code.