Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bridgedProvider test utilities in favour of ToProviderInfo #2812

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Jan 7, 2025

This PR is refactors the PF tests to remove the bridgedProvider utilities in favour of the new ToProviderInfo method on the providerbuilder class. Gets rid of some duplicated code.

@VenelinMartinov VenelinMartinov marked this pull request as draft January 7, 2025 11:34
@VenelinMartinov VenelinMartinov force-pushed the vvm/remove_redundant_bridged_provider_util branch from 74d9520 to 814b7b9 Compare January 7, 2025 11:39
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.66%. Comparing base (46b430a) to head (64c6d07).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2812      +/-   ##
==========================================
+ Coverage   68.63%   68.66%   +0.03%     
==========================================
  Files         325      325              
  Lines       41579    41579              
==========================================
+ Hits        28537    28551      +14     
+ Misses      11437    11423      -14     
  Partials     1605     1605              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov changed the title remove bridgedProvider utility Remove bridgedProvider utilities in favour of ToProviderInfo Jan 7, 2025
@VenelinMartinov VenelinMartinov changed the title Remove bridgedProvider utilities in favour of ToProviderInfo Remove bridgedProvider test utilities in favour of ToProviderInfo Jan 7, 2025
@VenelinMartinov VenelinMartinov marked this pull request as ready for review January 7, 2025 13:56
This was referenced Jan 7, 2025
@VenelinMartinov VenelinMartinov requested a review from t0yv0 January 7, 2025 16:24
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consuming #2805 sounds great. I don't understand why we are removing crosstests.DisableAccurateBridgePreview(). Can you explain what's going on there?

pkg/pf/tests/internal/cross-tests/diff.go Show resolved Hide resolved
Base automatically changed from vvm/add_to_provider_info_helper to master January 13, 2025 12:02
@VenelinMartinov VenelinMartinov force-pushed the vvm/remove_redundant_bridged_provider_util branch from 814b7b9 to 13d6e52 Compare January 13, 2025 12:04
@VenelinMartinov VenelinMartinov requested review from iwahbe and a team January 13, 2025 12:05
@VenelinMartinov VenelinMartinov force-pushed the vvm/remove_redundant_bridged_provider_util branch from 13d6e52 to 64c6d07 Compare January 13, 2025 13:37
@VenelinMartinov VenelinMartinov merged commit 27c2419 into master Jan 13, 2025
17 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/remove_redundant_bridged_provider_util branch January 13, 2025 15:30
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.101.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants