Interpret JSON Config values #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emas This is preperation for introducing a complex configuration middleware. The middleware will impose the additional requirement that infer based providers must serve a valid schema for CheckConfig to be called on them.
iwahbe
force-pushed
the
iwahbe/170/complex-config
branch
2 times, most recently
from
334fa8c to
ea8d6ff
Compare
thomas11
approved these changes
Sep 9, 2024
iwahbe
force-pushed
the
iwahbe/170/complex-config
branch
2 times, most recently
from
cf5b103 to
bd67f7e
Compare
t0yv0
reviewed
Sep 9, 2024
|
Does this need to cover old config in DiffConfig or CheckConfig suffices? Perhaps as a follow-up. |
t0yv0
approved these changes
Sep 9, 2024
`complexconfig` is marked as deprecated so that we can safely remove it in a later version.
iwahbe
force-pushed
the
iwahbe/170/complex-config
branch
from
ed79b84 to
6a7a911
Compare
I think it should be ok 🤞: From message DiffRequest {
...
// the new input values of resource to diff, copied from CheckResponse.inputs.
google.protobuf.Struct news = 4;
...
}I'll double check that this applies for providers as well. |
|
Check config is definitely called on new provider config before diff is called, so I think this should work by just overriding CheckConfig. |
|
This PR has been shipped in release v0.22.0. |
|
This PR has been shipped in release v0.23.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a middleware to handle decoding JSON encoded config values. The middleware is marked as deprecated, since we would like to remove this functionality as soon as pulumi/pulumi#15032 closes.
Fixes #171