Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin dependencies of TestAccOidcIam and TestAccCluster #1589

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

flostadler
Copy link
Contributor

Renovate pins our test dependencies (@pulumi/...), which ultimately leads to having multiple versions of dependencies like @pulumi/pulumi in node_modules. This is a known situation that can cause issues (e.g. pulumi/pulumi#13505).

Unless that core issue is resolved, I cannot see how we can pin @pulumi/... dependencies in tests. For now I'm gonna revert the failing tests to use version ranges, but we'll need to fix renovate.

Renovate pins our test dependencies (`@pulumi/...`), which ultimately leads to having multiple versions of dependencies like `@pulumi/pulumi` in node_modules. This is a known situation that can cause issues (e.g. pulumi/pulumi#13505).

Unless that core issue is resolved, I cannot see how we can pin `@pulumi/...` dependencies in tests. For now I'm gonna revert the failing tests to use version ranges, but we'll need to fix renovate.
@flostadler flostadler requested review from t0yv0 and corymhall January 16, 2025 12:23
@flostadler flostadler self-assigned this Jan 16, 2025
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@flostadler
Copy link
Contributor Author

Huh, that's weird. We're still getting:

  pulumi:pulumi:Stack (example-cluster-p-it-fv-az1758--cluster-6f3e505c):
    warning: using pulumi-resource-eks from $PATH at /home/runner/work/pulumi-eks/pulumi-eks/bin/pulumi-resource-eks
    warning: using pulumi-resource-eks from $PATH at /home/runner/work/pulumi-eks/pulumi-eks/bin/pulumi-resource-eks
    error: Running program '/tmp/p-it-fv-az1758--cluster-6f3e505c-4089464324/' failed with an unhandled exception:
    <ref *1> TypeError: Cannot read properties of undefined (reading 'isKnown')
        at /tmp/p-it-fv-az1758--cluster-6f3e505c-4089464324/node_modules/@pulumi/runtime/invoke.ts:270:44
        at Generator.next (<anonymous>)
        at fulfilled (/tmp/p-it-fv-az1758--cluster-6f3e505c-4089464324/node_modules/@pulumi/pulumi/runtime/invoke.js:18:58)
        at processTicksAndRejections (node:internal/process/task_queues:95:5) {
      promise: Promise { <rejected> [Circular *1] }
    }

Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting is fine!

I think we might be able to do this pulumi/pulumi-awsx#1493 which instructs make renovate to deduplicate the provider, but scale it to examples? That's unfortunate I guess. Adding example lockfiles could be ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants