Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Classic v6 updates #1710

Merged
merged 10 commits into from
Oct 17, 2024
Merged

Conversation

danielrbradley
Copy link
Member

@danielrbradley danielrbradley commented Oct 2, 2024

  • Upgrade dependencies
  • Add subscriptionId config to READMEs (and Pulumi.yaml where template exists).
  • Reformat markdown:
    • Remove "$" prefixes to make the bash valid.
    • Set mixed bash inputs and console outputs to use "console".

Closes pulumi/pulumi-azure#2336

- Upgrade dependencies
- Add subscriptionId config to READMEs (and Pulumi.yaml where template exists).
- Reformat markdown:
  - Remove "$" prefixes to make the bash valid.
  - Set mixed bash inputs and console outputs to use "console".
@danielrbradley danielrbradley self-assigned this Oct 2, 2024
Copy link

pulumi-staging bot commented Oct 2, 2024

🍹 The Update for pulumi/k8s-ci-cluster/27b44eeeb787b6038bb127c4b7243ed08846e9cb-236 was successful.

Resource Changes

    Name                                                         Type                                        Operation
+   password                                                     random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               create
+   primary-node-pool                                            gcp:container/nodePool:NodePool             create
+   gke                                                          pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-27b44eeeb787b6038bb127c4b7243ed08846e9cb-236  pulumi:pulumi:Stack                         create
+   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             create

Copy link

pulumi-staging bot commented Oct 2, 2024

🍹 The Destroy for pulumi/k8s-ci-cluster/27b44eeeb787b6038bb127c4b7243ed08846e9cb-236 was successful.

Resource Changes

    Name                                                         Type                                        Operation
-   password                                                     random:index/randomPassword:RandomPassword  delete
-   k8s-ci-cluster-27b44eeeb787b6038bb127c4b7243ed08846e9cb-236  pulumi:pulumi:Stack                         delete
-   gke                                                          pulumi:providers:kubernetes                 delete
-   primary-node-pool                                            gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               delete
-   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             delete

- Fix property changes which no longer compile.
- Fix case sensitivity changes.
- Fix deprecation notices.
- classic-azure-ts-appservice-springboot: Very niche combination which is really just running docker.
- classic-azure-ts-arm-template: Using manual ARM templates is not a good approach we should be encouraging.
- classic-azure-ts-dynamicresource: Dynamic resources are explained elsewhere and don't need a dedicated Azure classic example
For AKS, just keep the mean and keda examples. Remove:
- classic-azure-ts-aks-helm - covered by the mean example
- classic-azure-ts-aks-with-diagnostics - just a simple cluster
- classic-azure-ts-aks-multicluster - just more cluster setup
Copy link

🍹 The Update for pulumi/k8s-ci-cluster/51248731433253aba5709131b2f4de278c005f4c-262 was successful.

Resource Changes

    Name                                                         Type                                        Operation
+   primary-node-pool                                            gcp:container/nodePool:NodePool             create
+   gke                                                          pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-51248731433253aba5709131b2f4de278c005f4c-262  pulumi:pulumi:Stack                         create
+   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             create
+   password                                                     random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               create

Copy link

🍹 The Destroy for pulumi/k8s-ci-cluster/51248731433253aba5709131b2f4de278c005f4c-262 was successful.

Resource Changes

    Name                                                         Type                                        Operation
-   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             delete
-   password                                                     random:index/randomPassword:RandomPassword  delete
-   k8s-ci-cluster-51248731433253aba5709131b2f4de278c005f4c-262  pulumi:pulumi:Stack                         delete
-   gke                                                          pulumi:providers:kubernetes                 delete
-   primary-node-pool                                            gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               delete

Currently has a lot of build failures. The Typescript version is still available.
azure:network:PublicIp server-ip creating (0s) error:   sdk-v2/provider2.go:520: sdk.helper_schema: static IP allocation must be used when creating Standard SKU public IP addresses: [email protected]
azure:compute:LinuxVirtualMachineScaleSet vmscaleset: an `automatic_os_upgrade_policy` block cannot be specified when `upgrade_mode` is not set to `Automatic` or `Rolling`: [email protected]
@danielrbradley danielrbradley marked this pull request as ready for review October 16, 2024 14:59
Copy link

🍹 The Update for pulumi/k8s-ci-cluster/a8fbedeaba20d3d82d2ed1d12552c130f1092b83-263 was successful.

Resource Changes

    Name                                                         Type                                        Operation
+   primary-node-pool                                            gcp:container/nodePool:NodePool             create
+   gke                                                          pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-a8fbedeaba20d3d82d2ed1d12552c130f1092b83-263  pulumi:pulumi:Stack                         create
+   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             create
+   password                                                     random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               create

Copy link

🍹 The Destroy for pulumi/k8s-ci-cluster/a8fbedeaba20d3d82d2ed1d12552c130f1092b83-263 was successful.

Resource Changes

    Name                                                         Type                                        Operation
-   primary-node-pool                                            gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               delete
-   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             delete
-   password                                                     random:index/randomPassword:RandomPassword  delete
-   k8s-ci-cluster-a8fbedeaba20d3d82d2ed1d12552c130f1092b83-263  pulumi:pulumi:Stack                         delete
-   gke                                                          pulumi:providers:kubernetes                 delete

@danielrbradley danielrbradley merged commit 7220c2a into master Oct 17, 2024
46 of 47 checks passed
@danielrbradley danielrbradley deleted the danielrbradley/azure-classic-v6 branch October 17, 2024 09:58
@thoward
Copy link
Contributor

thoward commented Oct 18, 2024

@danielrbradley hi, i'm following up on a 404 from our documentation link checker for a link to the classic-azure-ts-arm-template directory. It seems to have been deleted in this PR, and I'm not sure if that was intentional or not from the context here.

@thoward
Copy link
Contributor

thoward commented Oct 18, 2024

Update, I see from this commit that it was intentional: c2f6d8a ... this was linked from a 2019-era blog post: https://www.pulumi.com/blog/2019-year-at-a-glance/ ... and also, we have an article on it that links to this code here: https://www.pulumi.com/registry/packages/azure/how-to-guides/classic-azure-ts-arm-template/

Should we remove all references to this directory or restore the directory and update the text there to label it as deprecated?

@thoward
Copy link
Contributor

thoward commented Oct 18, 2024

There are similar dead link issues for all the other example directories removed in that commit (e.g. classic-azure-ts-aks-with-diagnostics, classic-azure-ts-dynamicresource, classic-azure-ts-aks-helm, classic-azure-ts-appservice-springboot, etc). Each one has multiple blogs/docs with dead links to this code now.

@danielrbradley
Copy link
Member Author

Thanks for spotting this. These aren't maintained and so should be removed to avoid confusion for users browsing the examples, but I understand broken links are not good.

I think what would make sense for these very old articles is to update them with permalinks to the last maintained version:

Does that work for you @thoward?

Not sure how impactful or common of an issue we consider this .. I suppose we could theorecically proactively check for referenceing code before we modify or remove any in the future.

@thoward
Copy link
Contributor

thoward commented Oct 21, 2024

Yes! linking to the most recent commit hash will work in this case. I'll update the appropriate files for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure 6.0
3 participants