Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Azure Native examples to v2.1.1 #1467

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Update Azure Native examples to v2.1.1 #1467

merged 4 commits into from
Aug 3, 2023

Conversation

mnlumi
Copy link
Contributor

@mnlumi mnlumi commented Jul 25, 2023

No description provided.

@mnlumi mnlumi requested a review from cnunciato July 31, 2023 16:16
@mnlumi
Copy link
Contributor Author

mnlumi commented Jul 31, 2023

@cnunciato Would you be able review these updates? I've taken in the latest fixes for tests, there are still a few failing.

@lukehoban
Copy link
Member

I believe there are two issues across the failing examples:

azure-native:insights:Component (ai):
error: autorest/azure: Service returned an error. Status=400 Code="BadRequest" Message="Cannot set LogAnalytics as IngestionMode on current api-version" InnerError={"trace":["System.ArgumentException"]}

Sounds like a legitimate issue that needs to be fixed.

azure:lb:Rule (lbnatrule-http):
error: deleting urn:pulumi:p-it-fv-az1230--classic-az-c4ac5288::azure-ts-vm-scaleset::azure:lb/rule:Rule::lbnatrule-http: 1 error occurred:
* waiting for completion of Load Balancer "lba38cbe08" (Resource Group "vmss-rg5eeda2c8"): Code="NotFound" Message="Resource /subscriptions/***/resourceGroups//providers/Microsoft.Compute/tenants/38DF66CC-83A1-4EDF-A462-24DA3E8114E1 not found." Details=[]

Less clear what is happening here. Are you able to reproduce this issue locally in the TestAccAzureTsVmScaleset example?

@cnunciato cnunciato added this to the 0.92 milestone Jul 31, 2023
@cnunciato cnunciato added area/examples kind/engineering Work that is not visible to an external user emergent An issue that was added to the current milestone after planning labels Jul 31, 2023
@scottslowe
Copy link
Contributor

WRT to the first failure @lukehoban identified (the error with azure-native:insights:Component, it looks like we just need to specify the ingestion mode. Unfortunately, the API reference page (https://www.pulumi.com/registry/packages/azure-native/api-docs/insights/component/) doesn't provide any details on ingestion mode (that supporting type is blank/missing details).

@mnlumi
Copy link
Contributor Author

mnlumi commented Aug 2, 2023

Opened pulumi/registry#2966 for the api-docs.

@mnlumi
Copy link
Contributor Author

mnlumi commented Aug 2, 2023

@cnunciato @scottslowe All of the tests are passing 🎉

@cnunciato cnunciato merged commit d09b47f into master Aug 3, 2023
50 checks passed
@cnunciato cnunciato deleted the mnlumi/azurev2 branch August 3, 2023 02:32
@mnlumi
Copy link
Contributor Author

mnlumi commented Aug 3, 2023

Resolves #1437

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/examples emergent An issue that was added to the current milestone after planning kind/engineering Work that is not visible to an external user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants