Experiment: remove setuptools requirement #5658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mdellweg
force-pushed
the
remove_setuptools
branch
7 times, most recently
from
c98e389 to
4cd2001
Compare
Where exactly do we import from them? |
I first just removed the requirement, and tests were still passing. Probably because on pyton3.9 with pip you are almost guaranteed to have a version of setuptools. |
This refactors the use of pkg_resource to the more modern importlib_resources, that is supposed to be superseeded by importlib.resources eventually. In the fallout, the dependency on setuptools was dropped. [noissue]
mdellweg
force-pushed
the
remove_setuptools
branch
from
4cd2001 to
2826b1d
Compare
lubosmj
approved these changes
Aug 1, 2024
dkliban
approved these changes
Aug 5, 2024
rochacbruno
added a commit
to rochacbruno/pulpcore
that referenced
this pull request
Nov 28, 2024
rochacbruno
added a commit
to rochacbruno/pulpcore
that referenced
this pull request
Nov 28, 2024
rochacbruno
added a commit
to rochacbruno/pulpcore
that referenced
this pull request
Nov 28, 2024
rochacbruno
added a commit
to rochacbruno/pulpcore
that referenced
this pull request
Nov 28, 2024
Merged
rochacbruno
added a commit
to rochacbruno/pulpcore
that referenced
this pull request
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.