Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pug-linker] Add regression tests for #1261 #2687

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ForbesLindesay
Copy link
Member

This adds a test demonstrating that some of the issues reported in #1261 are still present. The snapshot will need updating once the issue is fixed.

@ForbesLindesay
Copy link
Member Author

I think the snapshots I've pushed now represent the behaviour the user expected to see. The only trouble is, I'm not really sure the output was "wrong" to start with. The issue is that append and prepend only really make sense at the top level of a file. By supporting them in nested locations, we end up creating a block as well as appending to the existing block. The simplest solution would be to disallow append/prepend except at the top level. I'm not confident that won't break some people's use cases though.

@rollingversions
Copy link

rollingversions bot commented May 1, 2020

There is no change log for this pull request yet.

Create a changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant