-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "Invariant Violation: Maximum update depth exceeded..." bug #1049
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am also facing an issue which can be resolved by this PR, can we get some merge this.
you guys should merge this, the issue is so serious and thanks God it works effectively |
We experience this bug as well and can confirm that this PR fixes the issue. |
I have the same issue |
Please merge this!! |
where is the fix? In which version? Looks like its not yet merged. Please merge this asap. Its BREAKING in react-native > 0.60 quick fix: |
Fix "Invariant Violation: Maximum update depth exceeded..." bug ptomasroos#1049【ScrollableTabView设置了 page={activeTab}报的错】
This PR fixes the condition used in the componentDidMount of the ScrollableTabView component that was causing infinite updates