Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LA64_DYNAREC] Added MOVLPD and MOVHPD opcodes #2198

Merged
merged 2 commits into from
Dec 25, 2024

Conversation

xiangzhai
Copy link
Contributor

Hi,

Please review my patch.

Thanks,
Leslie Zhai

Copy link
Collaborator

@ksco ksco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think MOVLPD and MOVHPD share exactly the same implementation, please refer to x86 specification.

@xiangzhai xiangzhai requested a review from ksco December 24, 2024 11:43
@xiangzhai xiangzhai marked this pull request as draft December 24, 2024 12:51
@xiangzhai xiangzhai force-pushed the la64_dynarec_scimark branch from 241052b to f794d0e Compare December 24, 2024 14:32
@xiangzhai
Copy link
Contributor Author

Fixed VSTELM_D wrong idx compared with VPICKVE2GR_D hi64 and lo64:

   0xfff6aed5c8:    addi.d    $r6,$r12,16(0x10)
   0xfff6aed5cc:    vpickve2gr.d    $r7,$vr2,0x1 ; hi64
(gdb) i r $vr2
vr2            {v16i8 = {0x6e, 0x50, 0xc8, 0xe7, 0x88, 0xe4, 0x68, 0x40, 0xfc, 0x40, 0x9d, 0xd3, 0x5e, 0x26, 0xe9, 0x3f}, v8i16 = {0x506e, 0xe7c8, 0xe488, 0x4068, 0x40fc, 0xd39d, 0x265e, 0x3fe9}, v4i32 = {0xe7c8506e, 0x4068e488, 0xd39d40fc, 0x3fe9265e}, v2i64 = {0x4068e488e7c8506e, 0x3fe9265ed39d40fc}, v4f32 = {0x0, 0x3, 0x7e080000, 0x1}, v2f64 = {0xc7, 0x0}}
(gdb) i r $r7
r7             0x3fe9265ed39d40fc  4605254282682122492
   0xfff6aed5d0:    vpickve2gr.d    $r7,$vr2,0x0 ; lo64
(gdb) i r $r7
r7             0x4068e488e7c8506e  4641210692660645998
   0xfff6aed5d4:    vstelm.d    $vr2,$r6,0,0x1   ; hi64
   0xfff6aed5d8:    ld.d    $r7,$r6,0
(gdb) i r $r7
r7             0x3fe9265ed39d40fc  4605254282682122492
   0xfff6aed5dc:    0x00368c05
...

Thanks,
Leslie Zhai

@xiangzhai xiangzhai marked this pull request as ready for review December 25, 2024 05:27
Copy link
Collaborator

@ksco ksco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is nothing to compare, the “fix” in commit 241052b is wrong.

Anyway, PR looks good now.

@xiangzhai
Copy link
Contributor Author

There is nothing to compare, the “fix” in commit 241052b is wrong.

Sorry for drunk coding.

Thanks,
Leslie Zhai

@ksco
Copy link
Collaborator

ksco commented Dec 25, 2024

@ptitSeb this can be merged now

@ptitSeb ptitSeb merged commit 9492b6c into ptitSeb:main Dec 25, 2024
27 checks passed
@xiangzhai
Copy link
Contributor Author

@ptitSeb Merry Christmas 🎄 Happy New Year 🍻

@xiangzhai xiangzhai deleted the la64_dynarec_scimark branch December 26, 2024 01:03
@ptitSeb
Copy link
Owner

ptitSeb commented Dec 26, 2024

@ptitSeb Merry Christmas 🎄 Happy New Year 🍻

Thank you. Happy new year to you too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants