-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for vertex and hyperedge values #12
Conversation
@@ -72,8 +98,8 @@ Removes a vertex from a given hyperedge for a hypergraph `h` and a given vertex- | |||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so maybe add a comment that trying to remove a vertex from a hyperedge when it is not present is not an error, earlier we wanted it to throw an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left some comments.
A major missing part is load/save functionality (which needs a design of storage format in the first place).
Given it starts to become a more complex design maybe we should switch to TOML or JSON with storage?
Also with metadata added probably we should consider saving the information about the types of a |
Co-Authored-By: pszufe <[email protected]>
According to my tests the best option for graph serialization is the |
On other note - since serialization is currenty being developed by the Salerno team - I definitely propose to handle that in a separate pull request. |
BSON.jl - OK. Serialization: who does work on serialization? |
I understand that @spagnuolocarmine and @aleant93 currently work on the hypergraph storage issues. |
This is independent (they are working on comments). We do not have do do it in this PR, but then please open an Issue to fix it later. |
Support for vertex and hyperedge values following the discussion at issue #2
This also includes several new tests and a bug correction for function
set_index!