bug fix

pszufe · Nov 19, 2023 · 1d6cfd5 · 1d6cfd5 · pszufe · Nov 19, 2023
1 parent 92c8436
commit 1d6cfd5
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "OSMToolset"
 uuid = "a1c25ae6-0f93-4b3a-bddf-c248cb99b9fa"
 authors = ["pszufe <[email protected]> and contributors"]
-version = "0.1.1"
+version = "0.1.2"
 
 [deps]
 CSV = "336ed68f-0bac-5ca0-87d4-7b16caf5d00b"

diff --git a/src/poi.jl b/src/poi.jl
@@ -140,7 +140,11 @@ function find_poi(filename::AbstractString; scrape_config::ScrapePOIConfig{T}=__
     relations_firstnode = Dict{Int, Node}()
     elemtype = :X
     elemid = -1
-    df= DataFrame()
+	# creates an empty data frame
+	df = DataFrame(;elemtype=Symbol[], elemid=Int[],nodeid=Int[],lat=Float64[],lon=Float64[],
+					key=String[], value=String[], 
+					(NamedTupleTools.fieldnames(T) .=> [Vector{ftype}() for ftype in NamedTupleTools.fieldtypes(T)])...  )
+
     io = open(filename, "r")
     sr = EzXML.StreamReader(io)
     i = 0

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -43,11 +43,18 @@ end
 
 config = DataFrame(key=["parking", "amenity"], values=["*", "parking"])
 df2 = find_poi(test_map; scrape_config=ScrapePOIConfig{NoneMetaPOI}(config))
+df3 = find_poi(test_map; scrape_config=ScrapePOIConfig{NoneMetaPOI}(DataFrame(key=String[], values=String[])))
+df4 = find_poi(test_map; scrape_config=ScrapePOIConfig{NoneMetaPOI}(DataFrame(key=["does not exist<!"], values=["*"])))
+
 # each parking space has an attractiveness range od 300 meters
 sindex2 = AttractivenessSpatIndex{NoneMetaPOI}(df2; get_range=a->300, get_group=a->:parking);
 
 @testset "CustomConfig" begin
     @test nrow(df2) > 0
+    @test nrow(df3) == 0
+    @test nrow(df4) == 0
+    @test df2[1:0,:] == df3
+    @test df2[1:0,:] == df4
     @test all(df2.key .∈ Ref(["amenity", "parking"]))
     att2 = attractiveness(sindex2, lla; aggregator= x -> length(x)==0 ? 0 : maximum(x), calculate_attractiveness = (a,dist) -> dist > 300 ? 0 : 300/dist   )
     @test fieldnames(att2) == (:parking,)