remove msys2 support #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkwouter
reviewed
Mar 31, 2024
scripts/005-gcc-stage2.sh
Outdated
| @@ -59,7 +59,7 @@ rm -rf build-$TARGET-stage2 && mkdir build-$TARGET-stage2 && cd build-$TARGET-st | |||
| --disable-libssp \ | |||
| --disable-multilib \ | |||
| --enable-threads=posix \ | |||
| --disable-libstdcxx-pch \ | |||
| # --disable-libstdcxx-pch \ | |||
There was a problem hiding this comment.
This will cause some issues, since the line below it will no longer be used. I suspect that's why the Mac build fails.
There was a problem hiding this comment.
Much better if totally remove it instead of commenting out for future usee
edit: maybe there's an issue with the missing package, can't test it because i don't have mac :(
|
This is strange... although I don't have a special interest in dropping |
|
I will close this now because the msys2 support is up and running, thanks @fjtrujy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--disable-libstdcxx-pchis the cause of thestd::filesystem::directory_iteratorand other libstdc++ issues