Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libz-dev #101

Merged
merged 1 commit into from
Dec 16, 2024
Merged

add libz-dev #101

merged 1 commit into from
Dec 16, 2024

Conversation

diamant3
Copy link
Member

fix based on the issue: pspdev/pspsdk#254

@sharkwouter
Copy link
Member

sharkwouter commented Dec 16, 2024

Thanks for the PR! This is good, but I do think @thearchivalone would also like to see an update to the README of the pspsdk. I think we might want to also add it to the ubuntu builds in the workflow in the pspsdk repo.

I'll merge this after the automated builds are done.

@sharkwouter sharkwouter merged commit 63224ff into master Dec 16, 2024
8 of 10 checks passed
@sharkwouter sharkwouter deleted the add-libz-dev branch December 16, 2024 12:41
@thearchivalone
Copy link

thearchivalone commented Dec 16, 2024

Thanks for the PR! This is good, but I do think @thearchivalone would also like to see an update to the README of the pspsdk. I think we might want to also add it to the ubuntu builds in the workflow in the pspsdk repo.

I'll merge this after the automated builds are done.

Documentation wasn't fully expected but I added a PR for it in the repo. The documentation I meant was having the issue in the tracker so others could see it if they ran into it themselves.

zlib-dev was added for at least the container part of https://github.com/pspdev/pspsdk/blob/master/.github/workflows/compilation.yml . I'm not sure where else it would need to go there if it's not testing using Ubuntu's libraries (assuming the container being ran is an Alpine Linux variant due to it using apk as the package manager; docker is fairly foreign to me as a container system). Thanks again, y'all.

@sharkwouter
Copy link
Member

Much appreciated! I thought we had an Ubuntu build in the workflow for the pspsdk, but it turns out that is not actually the case. That's good, then we don't have to update that. I think we just need this PR now and then this problem should be resolved: pspdev/psptoolchain#191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants