Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #20 Support for Account properties #46

Merged
merged 5 commits into from
Jun 1, 2019
Merged

Conversation

tonowie
Copy link
Contributor

@tonowie tonowie commented May 27, 2019

fixing issue #20 - account properties are now supported by the SDK

supported account property types are allow/block for address/mosaic/transactionType. There is also Sentinel type which does not seem to be supported by go or ts SDKs so I will ignore it for the time being. Raised issue #45 to handle the sentinel type.

tonowie added 5 commits May 25, 2019 23:47
implementation of address account properties
e2e test for address account properties creation + retrieval
junit tests for account properties model
account properties are now implemented together with tests. supported
account property types are allow/block address/mosaic/transactionType
@tonowie tonowie requested a review from alvin-reyes May 27, 2019 22:30
Copy link
Contributor

@alvin-reyes alvin-reyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@tonowie tonowie merged commit 5c4bd67 into master Jun 1, 2019
@tonowie tonowie deleted the issue/20-accountprops branch June 1, 2019 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants