feat(azure): check for minimal TLS version for Azure SQL server #5745
+251
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/azure
johannes-engler-mw
changed the title
johannes-engler-mw
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5745 +/- ##
==========================================
+ Coverage 89.83% 89.86% +0.02%
==========================================
Files 1128 1129 +1
Lines 35154 35173 +19
==========================================
+ Hits 31582 31609 +27
+ Misses 3572 3564 -8 ☔ View full report in Codecov by Sentry. |
puchy22
requested changes
Nov 15, 2024
| @@ -0,0 +1,30 @@ | |||
| { | |||
| "Provider": "azure", | |||
| "CheckID": "sqlserver_minimal_tls_version", | |||
There was a problem hiding this comment.
Suggested change
| "CheckID": "sqlserver_minimal_tls_version", | |
| "CheckID": "sqlserver_recommended_minimal_tls_version", |
| from prowler.providers.azure.services.sqlserver.sqlserver_client import sqlserver_client | ||
|
|
||
|
|
||
| class sqlserver_minimal_tls_version(Check): |
There was a problem hiding this comment.
Suggested change
| class sqlserver_minimal_tls_version(Check): | |
| class sqlserver_recommended_minimal_tls_version(Check): |
| report.status = "FAIL" | ||
| report.location = sql_server.location | ||
| report.status_extended = f"SQL Server {sql_server.name} from subscription {subscription} has no or an deprecated minimal TLS version set." | ||
| if sql_server.minimal_tls_version in ("1.2", "1.3"): |
There was a problem hiding this comment.
Could you make this check configurable? So if in the future version 1.2 is not recommended, you only have to change the configuration file and not the logic of the check. Here are examples of other checks that are configurable: https://docs.prowler.com/projects/prowler-open-source/en/latest/tutorials/configuration_file/#azure
| report.resource_id = sql_server.id | ||
| report.status = "FAIL" | ||
| report.location = sql_server.location | ||
| report.status_extended = f"SQL Server {sql_server.name} from subscription {subscription} has no or an deprecated minimal TLS version set." |
There was a problem hiding this comment.
Suggested change
| report.status_extended = f"SQL Server {sql_server.name} from subscription {subscription} has no or an deprecated minimal TLS version set." | |
| report.status_extended = f"SQL Server {sql_server.name} from subscription {subscription} is using TLS version {sql_server.minimal_tls_version} as minimal accepted which is not recommended. Please use one of the recommended versions: {<Here add the minimal recommended or the versions accepted>}" |
puchy22
requested changes
Nov 15, 2024
|
|
||
|
|
||
| class sqlserver_minimal_tls_version(Check): | ||
| def execute(self) -> Check_Report_Azure: |
There was a problem hiding this comment.
Suggested change
| def execute(self) -> Check_Report_Azure: | |
| def execute(self) -> List[Check_Report_Azure]: |
| @@ -0,0 +1,22 @@ | |||
| from prowler.lib.check.models import Check, Check_Report_Azure | |||
| from prowler.providers.azure.services.sqlserver.sqlserver_client import sqlserver_client | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| from typing import List |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Verify a secure configuration of SQL servers in Azure
Description
New check for minimum required TLS version of Azure SQL servers.
Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.