Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws): add MemoryDB service #5546

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sansns
Copy link
Contributor

@sansns sansns commented Oct 28, 2024

Context

Add MemoryDB Service

Description

Added MemoryDB Service, Client, and Service Test

This can be used to build a full suite of checks for the MemoryDB service

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sansns sansns requested review from a team as code owners October 28, 2024 15:33
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Oct 28, 2024
@sansns sansns changed the title feat(aws): Add MemoryDB Service feat(aws): add MemoryDB service Oct 28, 2024
@sansns
Copy link
Contributor Author

sansns commented Oct 30, 2024

@sergargar @jfagoagas Can either of you rerun the tests for this PR?

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.73%. Comparing base (93d2579) to head (86be9ea).
Report is 41 commits behind head on master.

Files with missing lines Patch % Lines
...roviders/aws/services/memorydb/memorydb_service.py 93.93% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5546      +/-   ##
==========================================
+ Coverage   89.66%   89.73%   +0.07%     
==========================================
  Files        1083     1087       +4     
  Lines       33462    33652     +190     
==========================================
+ Hits        30004    30198     +194     
+ Misses       3458     3454       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCloudSec
Copy link
Member

Hi @sansns, can you add a check to the service? If not, Prowler will not even execute this code. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants