Change FieldDescriptor::type() to not have the call_once behavior.
#16527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
This behavior is for lazily build descriptors, and those are for generated code which always have this field set. The `type()` function is called extensively in reflection based code and removing the call_once has significant performance impact. PiperOrigin-RevId: 625328922
copybara-service
bot
force-pushed
the
test_625328922
branch
from
4a7b51b to
182c948
Compare
|
Auto-closing Copybara pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
FieldDescriptor::type()to not have the call_once behavior.This behavior is for lazily build descriptors, and those are for generated code
which always have this field set.
The
type()function is called extensively in reflection based code andremoving the call_once has significant performance impact.